linux-kernel - Re: [PATCH] iio: health: max30100: use msleep() for long uncritical delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <683569ef-1f8c-02ad-337a-da7da8d6317e@kernel.org>
Date:   Sat, 21 Jan 2017 14:20:44 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matt Ranostay <matt.ranostay@...sulko.com>,
        Nicholas Mc Guire <hofrat@...dl.org>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Matt Ranostay <mranostay@...il.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: health: max30100: use msleep() for long uncritical
 delays

On 17/01/17 02:00, Matt Ranostay wrote:
> On Mon, Jan 16, 2017 at 7:35 AM, Nicholas Mc Guire <hofrat@...dl.org> wrote:
>> ulseep_range() uses hrtimers and provides no advantage over msleep()
>> for larger delays. Fix up the 35ms delays here to use msleep() and
>> reduce the load on the hrtimer subsystem.
> 
> Ok makes sense.  Also long as it guaranteed to be at least 35 milliseconds.
> 
> Reviewed-by: Matt Ranostay <matt.ranostay@...sulko.com>
Fair enough. Applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to play with it.

Thanks,

Jonathan
> 
>>
>> Fixes: commit 4d33615df58b ("iio: light: add MAX30100 oximeter driver support")
>> Link: http://lkml.org/lkml/2017/1/11/377
>> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
>> ---
>> Problem located with coccinelle script
>>
>> Patch was compile tested with: x86_64_defconfig + CONFIG_IIO=m +
>> CONFIG_MAX30100=m
>>
>> Patch is aginast 4.10-rc3 (localversion-next is next-20170116)
>>
>>  drivers/iio/health/max30100.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/health/max30100.c b/drivers/iio/health/max30100.c
>> index 90ab8a2d..9648c69 100644
>> --- a/drivers/iio/health/max30100.c
>> +++ b/drivers/iio/health/max30100.c
>> @@ -378,7 +378,7 @@ static int max30100_get_temp(struct max30100_data *data, int *val)
>>         if (ret)
>>                 return ret;
>>
>> -       usleep_range(35000, 50000);
>> +       msleep(35);
>>
>>         return max30100_read_temp(data, val);
>>  }
>> --
>> 2.1.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html