linux-kernel - Re: [PATCH 1/2] i2c: mux: pca954x: Export OF device ID table as module aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb601d79-515b-ccd1-1c07-c68adcb4ed70@axentia.se>
Date:   Sat, 21 Jan 2017 16:56:42 +0100
From:   Peter Rosin <peda@...ntia.se>
To:     Javier Martinez Canillas <javier@....samsung.com>,
        linux-kernel@...r.kernel.org
Cc:     Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org
Subject: Re: [PATCH 1/2] i2c: mux: pca954x: Export OF device ID table as
 module aliases

On 2017-01-16 14:54, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Acked-by: Peter Rosin <peda@...ntia.se>

> ---
> 
>  drivers/i2c/muxes/i2c-mux-pca954x.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
> index dd18b9ccb1f4..a0232e079545 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -148,6 +148,7 @@ static const struct of_device_id pca954x_of_match[] = {
>  	{ .compatible = "nxp,pca9548", .data = &chips[pca_9548] },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, pca954x_of_match);
>  #endif
>  
>  /* Write to mux register. Don't use i2c_transfer()/i2c_smbus_xfer()
>