linux-kernel - Re: [tip:timers/core] x86/timer: Make delay() during early bootup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a5d0332-ae89-7f42-11a9-b3fee1640551@suse.cz>
Date:   Sat, 21 Jan 2017 08:35:14 +0100
From:   Jiri Slaby <jslaby@...e.cz>
To:     peterz@...radead.org, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, mingo@...nel.org,
        tglx@...utronix.de, andy.shevchenko@...il.com, hpa@...or.com,
        linux-tip-commits@...r.kernel.org
Subject: Re: [tip:timers/core] x86/timer: Make delay() during early bootup

On 01/20/2017, 03:40 PM, tip-bot for Jiri Slaby wrote:
> Commit-ID:  bf3304d996fbb993bad6be09cafde39cc2db72bb
> Gitweb:     http://git.kernel.org/tip/bf3304d996fbb993bad6be09cafde39cc2db72bb
> Author:     Jiri Slaby <jslaby@...e.cz>
> AuthorDate: Thu, 19 Jan 2017 12:47:30 +0100
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Fri, 20 Jan 2017 09:45:22 +0100
> 
> x86/timer: Make delay() during early bootup
> 
> When a panic happens during bootup, "Rebooting in X seconds.." is
> shown, but reboot happens immediatelly. It is because panic() uses mdelay()
> and mdelay() calls __const_udelay() immediately, which is does not
> work while booting.

The 'is' is superfluous after your edit now. But I guess, you cannot
change it given it is in the tree.

> --- a/arch/x86/lib/delay.c
> +++ b/arch/x86/lib/delay.c
> @@ -156,13 +156,13 @@ EXPORT_SYMBOL(__delay);
>  
>  inline void __const_udelay(unsigned long xloops)
>  {
> +	unsigned long lpj = this_cpu_read(cpu_info.loops_per_jiffy) ? : loops_per_jiffy;

And thanks for fixing the 'lpf' brain damage :).

-- 
js
suse labs