linux-kernel - Re: [PATCH] Input: max11801_ts - drop call to input_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd170278-d556-2f73-cdbe-ee69f9a19423@roeck-us.net>
Date:   Sun, 22 Jan 2017 03:25:57 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org
Cc:     Zhang Jiejing <jiejing.zhang@...escale.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: max11801_ts - drop call to input_set_drvdata()

On 01/21/2017 11:38 PM, Dmitry Torokhov wrote:
> Nobody calls input_get_drvdata() so setting it is not required.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Acked-by: Guenter Roeck <linux@...ck-us.net>

Surprisingly, there is about a dozen of those. I'll send a series of
coccinelle generated patches later.

Guenter

> ---
>  drivers/input/touchscreen/max11801_ts.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c
> index d87b89da114e..a595ae5284e3 100644
> --- a/drivers/input/touchscreen/max11801_ts.c
> +++ b/drivers/input/touchscreen/max11801_ts.c
> @@ -199,7 +199,6 @@ static int max11801_ts_probe(struct i2c_client *client,
>  	__set_bit(BTN_TOUCH, input_dev->keybit);
>  	input_set_abs_params(input_dev, ABS_X, 0, MAX11801_MAX_X, 0, 0);
>  	input_set_abs_params(input_dev, ABS_Y, 0, MAX11801_MAX_Y, 0, 0);
> -	input_set_drvdata(input_dev, data);
>
>  	max11801_ts_phy_init(data);
>
>