linux-kernel - Re: [PATCH 1/1] EDAC: always return an initialized value in knl_show_interleave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170122161023.hmxbgiwse3f2qne6@pd.tnic>
Date:   Sun, 22 Jan 2017 17:10:23 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] EDAC: always return an initialized value in
 knl_show_interleave_mode

On Sun, Jan 22, 2017 at 04:50:31PM +0100, Nicolas Iooss wrote:
>  	if (!is_knl)
>  		return interleave_mode(reg) ?
> 			"[8:6]" : "[8:6]XOR[18:16]";
>  	else
>  		return knl_intlv_mode[knl_interleave_mode(reg)];
> 
> Would this be good for you?

Ah, yes we interleave on address bits [8:6] when the bitield is 0 on KNL
while bitfield 0 for the rest of the families gives interleave mode for
the XOR of bits [8:6] and [18:16]. Good catch.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.