linux-kernel - Re: [PATCH v3] vfio error recovery: kernel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170123010102-mutt-send-email-mst@kernel.org>
Date:   Mon, 23 Jan 2017 01:01:12 +0200
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        Alex Williamson <alex.williamson@...hat.com>,
        kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v3] vfio error recovery: kernel support

On Sun, Jan 22, 2017 at 04:01:28PM +0800, Jason Wang wrote:
> 
> 
> On 2017年01月22日 15:38, Michael S. Tsirkin wrote:
> > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
> > index 26c155b..6b0f416 100644
> > --- a/include/linux/virtio_config.h
> > +++ b/include/linux/virtio_config.h
> > @@ -159,7 +159,17 @@ static inline bool virtio_has_iommu_quirk(const struct virtio_device *vdev)
> >   	 * Note the reverse polarity of the quirk feature (compared to most
> >   	 * other features), this is for compatibility with legacy systems.
> >   	 */
> > -	return !virtio_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM);
> > +	if (virtio_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM))
> > +		return false;
> > +
> > +	/*
> > +	 * fastboot emulator for ARM puts virtio devices behind an SMMU
> > +	 * and never bypasses it for legacy devices.
> > +	 */
> > +	if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
> > +		return virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
> > +
> > +	return true;
> >   }
> 
> Hi Michael:
> 
> This part of codes seems unrelated.
> 
> Thanks

Of course it is, thanks!