linux-kernel - [tip:x86/debug] x86/crash: Update the stale comment in reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-a8d4c8246b290ce97f88752d833804843041ac84@git.kernel.org>
Date:   Mon, 23 Jan 2017 00:01:22 -0800
From:   tip-bot for Xunlei Pang <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        robert@...lancnet.us, xlpang@...hat.com, hpa@...or.com,
        bhe@...hat.com, bp@...en8.de, torvalds@...ux-foundation.org,
        mingo@...nel.org, akpm@...ux-foundation.org, tglx@...utronix.de,
        dyoung@...hat.com
Subject: [tip:x86/debug] x86/crash: Update the stale comment in
 reserve_crashkernel()

Commit-ID:  a8d4c8246b290ce97f88752d833804843041ac84
Gitweb:     http://git.kernel.org/tip/a8d4c8246b290ce97f88752d833804843041ac84
Author:     Xunlei Pang <xlpang@...hat.com>
AuthorDate: Mon, 23 Jan 2017 14:48:23 +0800
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Mon, 23 Jan 2017 08:57:55 +0100

x86/crash: Update the stale comment in reserve_crashkernel()

CRASH_KERNEL_ADDR_MAX has been missing for a long time,
update it with a more detailed explanation.

Signed-off-by: Xunlei Pang <xlpang@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Baoquan He <bhe@...hat.com>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Dave Young <dyoung@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Robert LeBlanc <robert@...lancnet.us>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: kexec@...ts.infradead.org
Link: http://lkml.kernel.org/r/1485154103-18426-1-git-send-email-xlpang@redhat.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/kernel/setup.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 4cfba94..eb69b14 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -575,7 +575,9 @@ static void __init reserve_crashkernel(void)
 	/* 0 means: find the address automatically */
 	if (crash_base <= 0) {
 		/*
-		 *  kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
+		 * Set CRASH_ADDR_LOW_MAX upper bound for crash memory,
+		 * as old kexec-tools loads bzImage below that, unless
+		 * "crashkernel=size[KMG],high" is specified.
 		 */
 		crash_base = memblock_find_in_range(CRASH_ALIGN,
 						    high ? CRASH_ADDR_HIGH_MAX