linux-kernel - Re: [PATCH 2/4] perf hists browser: Add e/c key handlers to expand callchain for current entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170123090137.GA25780@krava>
Date:   Mon, 23 Jan 2017 10:01:37 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, David Ahern <dsahern@...il.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 2/4] perf hists browser: Add e/c key handlers to expand
 callchain for current entry

On Fri, Jan 20, 2017 at 01:43:26PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 20, 2017 at 01:41:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Jan 20, 2017 at 10:20:30AM +0100, Jiri Olsa escreveu:
> > > Currently we allow only to expand or collapse all entries
> > > in the browser with E or C keys. Allow user to expand or
> > > collapse only current entry in the browser with e or c key.
> > 
> > I guess we can start with this but then fix it to collapse just the
> > subtree, not the whole tree for the current hist_entry, for big
> > callchains we can have multiple sub(sub)trees, being able to
> > expand/collapse just from where we are in a callchain seems even better.
> > 
> > Applying anyway, better than what we have now,
> 
> Also I think that pressing 'e' on an already expanded tree should mean
> 'c', i.e. make it a toggle, so that we can go back and forth faster.

yep, that was my impression also, but wanted to keep the current way

I think we could use only C/c keys to toggle 'collapse all'/'collapse current'

thanks,
jirka