linux-kernel - Re: [PATCH linux v1 2/2] drivers: hwmon: hwmon driver for ASPEED AST2400/2500 PWM and Fan tach controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2017 08:06:16 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jaghathiswari Rankappagounder Natarajan <jaghu@...gle.com>
Cc:     kbuild-all@...org, openbmc@...ts.ozlabs.org, joel@....id.au,
        jdelvare@...e.com, linux@...ck-us.net, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, corbet@....net,
        linux-doc@...r.kernel.org, robh+dt@...nel.org,
        mark.rutland@....com, devicetree@...r.kernel.org,
        Jaghathiswari Rankappagounder Natarajan <jaghu@...gle.com>
Subject: Re: [PATCH linux v1 2/2] drivers: hwmon: hwmon driver for ASPEED
 AST2400/2500 PWM and Fan tach controller

Hi Jaghathiswari,

[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on v4.10-rc5 next-20170120]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jaghathiswari-Rankappagounder-Natarajan/Support-for-ASPEED-AST2400-AST2500-PWM-and-Fan-Tach-driver/20170110-093628
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: i386-randconfig-i1-01230650 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/hwmon/aspeed-pwm-tacho.c: In function 'aspeed_create_type':
>> drivers/hwmon/aspeed-pwm-tacho.c:656:41: warning: 'div_h' is used uninitialized in this function [-Wuninitialized]
     priv->type_pwm_clock_division_h[index] = div_h;
                                            ^

vim +/div_h +656 drivers/hwmon/aspeed-pwm-tacho.c

   640	 * The PWM frequency = 24MHz / (type M clock division L bit *
   641	 * type M clock division H bit * (type M PWM period bit + 1))
   642	 * Calculate type M clock division L bit and H bits given the other values
   643	 */
   644	static int aspeed_create_type(struct device_node *child,
   645				      struct aspeed_pwm_tacho_data *priv,
   646				      u8 index)
   647	{
   648		u8 period, div_l, div_h;
   649		bool enable;
   650		u8 mode, div;
   651		u16 unit;
   652	
   653		of_property_read_u8(child, "pwm_period", &period);
   654		of_property_read_u8(child, "pwm_clock_division_h", &div_h);
   655		of_property_read_u8(child, "pwm_clock_division_l", &div_l);
 > 656		priv->type_pwm_clock_division_h[index] = div_h;
   657		priv->type_pwm_clock_division_l[index] = div_l;
   658		priv->type_pwm_clock_unit[index] = period;
   659		aspeed_set_pwm_clock_values(priv->base, index, div_h, div_l, period);
   660	
   661		enable = of_property_read_bool(child, "fan_tach_enable");
   662		aspeed_set_tacho_type_enable(priv->base, index, enable);
   663	
   664		of_property_read_u8(child, "fan_tach_clock_division", &div);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27607 bytes)