lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 23 Jan 2017 10:19:56 +0100
From:   Paolo Bonzini <>
To:     Christian Borntraeger <>,
        SF Markus Elfring <>,,,
        Cornelia Huck <>,
        Heiko Carstens <>,
        Martin Schwidefsky <>,
        Radim Krčmář <>
Cc:     LKML <>,
Subject: Re: [PATCH] KVM: s390: Move two error code assignments in

On 23/01/2017 09:22, Christian Borntraeger wrote:
> Patches that changes open coded things to common helpers or things like
> kmalloc_array where appropriate or things that make the code more robust
> are fine and welcome, but I am not going to take this as it just shuffles
> things around. It does not fix anything and it does not improve the code,
> but it certainly carries the risk of breaking something (yes in this case
> it looks perfectly fine, though).


	if (...)
		return r;

is the way it's done everywhere else in KVM.


Powered by blists - more mailing lists