linux-kernel - Re: [PATCH] mm: do not export ioremap_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8088cdd7-7abb-94ed-3bea-44d819045573@nvidia.com>
Date:   Sun, 22 Jan 2017 17:30:46 -0800
From:   John Hubbard <jhubbard@...dia.com>
To:     zhong jiang <zhongjiang@...wei.com>, <akpm@...ux-foundation.org>,
        <minchan@...nel.org>, <mhocko@...nel.org>
CC:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: do not export ioremap_page_range symbol for external
 module



On 01/22/2017 05:14 PM, zhong jiang wrote:
> On 2017/1/22 20:58, zhongjiang wrote:
>> From: zhong jiang <zhongjiang@...wei.com>
>>
>> Recently, I find the ioremap_page_range had been abusing. The improper
>> address mapping is a issue. it will result in the crash. so, remove
>> the symbol. It can be replaced by the ioremap_cache or others symbol.
>>
>> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
>> ---
>>  lib/ioremap.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/lib/ioremap.c b/lib/ioremap.c
>> index 86c8911..a3e14ce 100644
>> --- a/lib/ioremap.c
>> +++ b/lib/ioremap.c
>> @@ -144,4 +144,3 @@ int ioremap_page_range(unsigned long addr,
>>
>>  	return err;
>>  }
>> -EXPORT_SYMBOL_GPL(ioremap_page_range);
> self nack
>

heh. What changed your mind?