linux-kernel - Re: [PATCH] HID: get rid of HID_QUIRK_NO_INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1701231513240.25515@cbobk.fhfr.pm>
Date:   Mon, 23 Jan 2017 15:15:36 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        David Herrmann <dh.herrmann@...glemail.com>,
        Oliver Neukum <oneukum@...e.de>,
        Jason Gerecke <killertofu@...il.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] HID: get rid of HID_QUIRK_NO_INIT_REPORTS

On Thu, 5 Jan 2017, Benjamin Tissoires wrote:

> I don't know what to do about hiddev too. I don't know if we have actual 
> users besides some debugging tools. And hidraw is much better than 
> hiddev, so ideally, I'd like to remove it some way.

First, I'd love to get rid of HID_QUIRK_NO_INIT_REPORTS; I am 
whole-heartedly convinced that initializing reports was a big mistake to 
start with, but changing history is hard :)

Regarding hiddev -- there actually are 'legitimate' non-debug users; for 
example NUT (UPS management software) has been using it last time I 
looked. I am pretty sure there are more.

So we'd rather be careful not to break hiddev by default.

I'll think about your RFC a little bit more.

Thanks,

-- 
Jiri Kosina
SUSE Labs