lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 23 Jan 2017 17:00:38 +0200
From:   Andy Shevchenko <>
To:     Dmitry Torokhov <>,
        "Rafael J. Wysocki" <>
        Mika Westerberg <>,
        Hans de Goede <>
Subject: Re: [PATCH 1/2] device property: export code duplicating array of
 property entries

On Sun, 2017-01-22 at 23:38 -0800, Dmitry Torokhov wrote:
> When augmenting ACPI-enumerated devices with additional property data
> based
> on DMI info, a module has often several potential property sets, with
> only
> one being active on a given box. In order to save memory it should be
> possible to mark everything and __initdata or __initconst, execute DMI
> match early, and duplicate relevant properties. Then kernel will
> discard
> the rest of them.

Looks good to me.

Reviewed-by: Andy Shevchenko <>

Couple of style nitpicks.

> +struct property_entry *property_entries_dup(
> +				const struct property_entry
> *properties)

Can we use

struct propert_entry *


> +struct property_entry *property_entries_dup(
> +				const struct property_entry
> *properties);


Andy Shevchenko <>
Intel Finland Oy

Powered by blists - more mailing lists