linux-kernel - [PATCH v2] firmware/Makefile: force recompilation if makefile changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170123150727.4883-1-mcgrof@kernel.org>
Date:   Mon, 23 Jan 2017 07:07:27 -0800
From:   "Luis R. Rodriguez" <mcgrof@...nel.org>
To:     mmarek@...e.com
Cc:     linux-kbuild@...r.kernel.org, ming.lei@...onical.com,
        gregkh@...uxfoundation.org, teg@...m.no,
        linux-kernel@...r.kernel.org, dwmw2@...radead.org,
        "Luis R. Rodriguez" <mcgrof@...nel.org>
Subject: [PATCH v2] firmware/Makefile: force recompilation if makefile changes

If you modify the target asm we currently do not force the
recompilation of the firmware files. The target asm is in
the firmware/Makefile, peg this file as a dependency to
require re-compilation of firmware targets when the asm
changes.

Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
---

Michal,

I had this patch as part of my linker table series [0] but have split it
off as its a small atomic separate change and can go in separately. Greg
prefers this be reviewed by the kbuild tree so sending it your way.
This v2 has no modifications, just resending it to the kbuild tree.

[0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org

 firmware/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/firmware/Makefile b/firmware/Makefile
index e297e1b52636..fa3e81c2a97b 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW   $@
 wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \
 		include/config/ppc32.h include/config/ppc64.h \
 		include/config/superh32.h include/config/superh64.h \
-		include/config/x86_32.h include/config/x86_64.h)
+		include/config/x86_32.h include/config/x86_64.h \
+		firmware/Makefile)
 
 $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps)
 	$(call cmd,fwbin,$(patsubst %.gen.S,%,$@))
-- 
2.11.0