linux-kernel - Re: [PATCH v5 01/14] devicetree: bindings: add bindings for ahci-da850

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170123154931.zyrcg5grqvia435t@rob-hp-laptop>
Date:   Mon, 23 Jan 2017 09:49:31 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sekhar Nori <nsekhar@...com>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Kevin Hilman <khilman@...nel.org>,
        Patrick Titiano <ptitiano@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Tejun Heo <tj@...nel.org>, Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        David Lechner <david@...hnology.com>,
        linux-ide@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 01/14] devicetree: bindings: add bindings for
 ahci-da850

On Fri, Jan 20, 2017 at 07:02:08PM +0530, Sekhar Nori wrote:
> Hi Rob,
> 
> On Friday 20 January 2017 04:51 PM, Bartosz Golaszewski wrote:
> > Add DT bindings for the TI DA850 AHCI SATA controller.
> > 
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> Could you ack this binding?

First I'm seeing it that I recall and v5? That either means the DT list 
wasn't copied or new versions are being sent out faster than can be 
reviewed. Sending new versions puts you at the back of the queue.

> 
> Thanks,
> Sekhar
> 
> > ---
> >  Documentation/devicetree/bindings/ata/ahci-da850.txt | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/ata/ahci-da850.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/ata/ahci-da850.txt b/Documentation/devicetree/bindings/ata/ahci-da850.txt
> > new file mode 100644
> > index 0000000..268fe87
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ata/ahci-da850.txt
> > @@ -0,0 +1,15 @@
> > +Device tree binding for the TI DA850 AHCI SATA Controller
> > +---------------------------------------------------------
> > +
> > +Required properties:
> > +  - compatible: must be "ti,da850-ahci"
> > +  - reg: physical base addresses and sizes of the controller's register areas

Need to state how many and what the regions are.

> > +  - interrupts: interrupt specifier (refer to the interrupt binding)
> > +
> > +Example:
> > +
> > +	sata: sata@...000 {
> > +		compatible = "ti,da850-ahci";
> > +		reg = <0x218000 0x2000>, <0x22c018 0x4>;
> > +		interrupts = <67>;
> > +	};
> > 
>