lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 23 Jan 2017 17:02:34 +0100
From:   Arnd Bergmann <>
To:     Vlastimil Babka <>
Cc:     Andrew Morton <>,
        Mel Gorman <>,
        Michal Hocko <>,
        Johannes Weiner <>,
        Joonsoo Kim <>,,
        Linux Kernel Mailing List <>
Subject: Re: [PATCH] mm: ensure alloc_flags in slow path are initialized

On Mon, Jan 23, 2017 at 1:55 PM, Vlastimil Babka <> wrote:
> On 01/23/2017 01:16 PM, Arnd Bergmann wrote:

>> To be honest, I can't figure that out either, maybe it is or
>> maybe not,
> Seems the report is correct and not false positive, in scenario when we goto
> nopage before the assignment, and then goto retry because of __GFP_NOFAIL.

Ok, thanks for checking!

>> but moving the existing initialization up a little
>> higher looks safe and makes it obvious to both me and gcc that
>> the initialization comes before the first use.
>> Fixes: 74eaa4a97e8e ("mm: consolidate GFP_NOFAIL checks in the allocator
>> slowpath")
> That's a non-stable -next commit ID for mmotm patch:
> mm-consolidate-gfp_nofail-checks-in-the-allocator-slowpath.patch
> The patch itself was OK, the problem only comes from integration with
> another mmotm patch (also independently OK):
> mm-page_alloc-fix-premature-oom-when-racing-with-cpuset-mems-update.patch
> By their ordering in mmotm, it would work to treat this as a fix for the
> GFP_NOFAIL patch, possibly merged into it.

Ok. I only tracked down which commit introduced the warning, which was
the one above.


Powered by blists - more mailing lists