linux-kernel - Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170123165245.7zy7nf3cx5o4vvh3@pd.tnic>
Date:   Mon, 23 Jan 2017 17:52:45 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     arnd@...db.de, mmarek@...e.com, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        airlied@...ux.ie, davem@...emloft.net, linux@...linux.org.uk,
        slash.tmp@...e.fr, daniel.vetter@...ll.ch,
        rmk+kernel@...linux.org.uk, msalter@...hat.com, jengelh@...i.de,
        hch@...radead.org, tklauser@...tanz.ch, mpe@...erman.id.au
Subject: Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote:
> This header file is exported, thus move it to uapi.

Why? Why is this damn thing exported in the first place?

The moment we decide to change an MSR name or even remove it from that
file, we break userspace. And what for, because userspace is using some
arbitrary header file which was meant to be for the kernel solely.

NAKed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.