linux-kernel - Re: [PATCH v3 1/2] devicetree: document new marvell-8xxx and pwrseq-sd8787 options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170123170409.rnmnf4ssjpd2yk3l@rob-hp-laptop>
Date:   Mon, 23 Jan 2017 11:04:09 -0600
From:   Rob Herring <robh@...nel.org>
To:     Matt Ranostay <matt@...ostay.consulting>
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        ulf.hansson@...aro.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/2] devicetree: document new marvell-8xxx and
 pwrseq-sd8787 options

On Fri, Jan 20, 2017 at 09:50:38PM -0800, Matt Ranostay wrote:
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Matt Ranostay <matt@...ostay.consulting>
> ---
>  .../devicetree/bindings/mmc/mmc-pwrseq-sd8787.txt          | 14 ++++++++++++++
>  .../devicetree/bindings/net/wireless/marvell-8xxx.txt      |  7 ++++++-
>  2 files changed, 20 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.txt
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.txt b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.txt
> new file mode 100644
> index 000000000000..4bb56766982e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.txt
> @@ -0,0 +1,14 @@
> +* Marvell SD8787 power sequence provider
> +
> +Required properties:
> +- compatible: must be "mmc-pwrseq-sd8787".
> +- powerdown-gpio: contains a power down GPIO specifier with active state
> +- reset-gpio: contains a reset GPIO specifier with active state

My comments on the previous v3 still apply.

> +
> +Example:
> +
> +	wifi_pwrseq: wifi_pwrseq {
> +		compatible = "mmc-pwrseq-sd8787";
> +		powerdown-gpio = <&twl_gpio 0 GPIO_ACTIVE_LOW>;
> +		reset-gpio = <&twl_gpio 1 GPIO_ACTIVE_LOW>;
> +	}