linux-kernel - Re: [PATCH] mn10300: fix build error of missing fpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7502.1485213978@warthog.procyon.org.uk>
Date:   Mon, 23 Jan 2017 23:26:18 +0000
From:   David Howells <dhowells@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     dhowells@...hat.com, LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-am33-list@...hat.com,
        kbuild test robot <fengguang.wu@...el.com>
Subject: Re: [PATCH] mn10300: fix build error of missing fpu_save()

Randy Dunlap <rdunlap@...radead.org> wrote:

> b. make <asm/switch_to.h> know about CONFIG_FPU not enabled
> 
> David, which one do you prefer?

b.

> From: Randy Dunlap <rdunlap@...radead.org>
> 
> When CONFIG_FPU is not enabled on arch/mn10300, <asm/switch_to.h>
> causes a build error with a call to fpu_save():
> 
> kernel/built-in.o: In function `.L410':
> core.c:(.sched.text+0x28a): undefined reference to `fpu_save'
> 
> Fix this by defining switch_fpu() in <asm/switch_to.h> only when
> CONFIG_FPU is enabled.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Cc:	David Howells <dhowells@...hat.com>
> ---
>  arch/mn10300/include/asm/switch_to.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lnx-410-rc4.orig/arch/mn10300/include/asm/switch_to.h
> +++ lnx-410-rc4/arch/mn10300/include/asm/switch_to.h
> @@ -16,7 +16,7 @@
>  struct task_struct;
>  struct thread_struct;
>  
> -#if !defined(CONFIG_LAZY_SAVE_FPU)
> +#if defined(CONFIG_FPU) && !defined(CONFIG_LAZY_SAVE_FPU)
>  struct fpu_state_struct;
>  extern asmlinkage void fpu_save(struct fpu_state_struct *);
>  #define switch_fpu(prev, next)						\

Reviewed-by: David Howells <dhowells@...hat.com>