linux-kernel - Re: [PATCH] drm: bridge: dw-hdmi: fix building without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0aae7bc-e16b-e253-4066-09a3f4bdbc68@codeaurora.org>
Date:   Tue, 24 Jan 2017 11:59:09 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     David Airlie <airlied@...ux.ie>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Jose Abreu <Jose.Abreu@...opsys.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: bridge: dw-hdmi: fix building without CONFIG_OF



On 01/23/2017 05:50 PM, Arnd Bergmann wrote:
> The of_node member in struct drm_bridge is hidden when CONFIG_OF
> is disabled, causing a build error:
>
> drivers/gpu/drm/bridge/dw-hdmi.c: In function '__dw_hdmi_probe':
> drivers/gpu/drm/bridge/dw-hdmi.c:2063:14: error: 'struct drm_bridge' has no member named 'of_node'
>
> We could fix this either using a Kconfig dependency on CONFIG_OF
> or making the one line conditional. The latter gives us better
> compile test coverage, so this is what I'm doing here.
>
> Fixes: 69497eb9234e ("drm: bridge: dw-hdmi: Implement DRM bridge registration")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for fixing this, queued to drm-misc.

Archit

> ---
>  drivers/gpu/drm/bridge/dw-hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
> index 4fda0717e789..9a9ec27d9e28 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -2060,7 +2060,9 @@ __dw_hdmi_probe(struct platform_device *pdev,
>
>  	hdmi->bridge.driver_private = hdmi;
>  	hdmi->bridge.funcs = &dw_hdmi_bridge_funcs;
> +#ifdef CONFIG_OF
>  	hdmi->bridge.of_node = pdev->dev.of_node;
> +#endif
>
>  	ret = dw_hdmi_fb_registered(hdmi);
>  	if (ret)
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project