linux-kernel - Re: [PATCH] USB: Add quirk for WORLDE easykey.25 MIDI keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGUtLj9ne2_7Cr6zA4zvBHcUKLUSGjZ0_TDoz3pTbp6htK_ruw@mail.gmail.com>
Date:   Tue, 24 Jan 2017 09:31:09 +0100
From:   Lukáš Lalinský <lukas@...gene.sk>
To:     Oliver Neukum <oneukum@...e.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] USB: Add quirk for WORLDE easykey.25 MIDI keyboard

On Tue, Jan 24, 2017 at 8:37 AM, Lukáš Lalinský <lukas@...gene.sk> wrote:
> On Tue, Jan 24, 2017 at 8:32 AM, Oliver Neukum <oneukum@...e.com> wrote:
>> Am Montag, den 23.01.2017, 19:36 +0100 schrieb Lukáš Lalinský:
>>> I have uploaded both captures here -
>>> https://gist.github.com/lalinsky/83148a827d5cd43e79e377d8e1b5ed0d
>>
>> Indeed it is does not set a configuration. Either the capture
>> is incomplete or device and host violate the standard. A device
>> may be left unconfigured.
>
> Is this may or may not? I'm not familiar with USB, so I assumed if
> there is only one configuration and there is always one active, it
> does not need to be set explicitly because the correct one is already
> active.
>
>> We need to read the descriptors even if we
>> see only one configuration to get the power budgeting right.
>
> Aren't those in the CONFIGURATION descriptors? Reading the STRING
> descriptor is probably only useful if you need to print the
> configuration details somewhere.

I re-ran the capture on a Windows 7 host. The previous capture was
missing data, probably due to interactions of the Linux host and
Windows VM.

https://gist.github.com/lalinsky/2ec7d74b049b448b1f7032d8861ca4a2

It does set the configuration, but does not request the string descriptor.

Lukas