linux-kernel - Re: [PATCH] cxl: drop unused header asm/pnv-pci.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k29kaih9.fsf@concordia.ellerman.id.au>
Date:   Tue, 24 Jan 2017 20:57:06 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Greg Kurz <groug@...d.org>, linuxppc-dev@...ts.ozlabs.org
Cc:     linux-kernel@...r.kernel.org,
        Frederic Barrat <fbarrat@...ux.vnet.ibm.com>,
        Ian Munsie <imunsie@....ibm.com>
Subject: Re: [PATCH] cxl: drop unused header asm/pnv-pci.h

Greg Kurz <groug@...d.org> writes:

> The kernel API does not use anything from this header file.

That's actually hard to prove in general, because pnv-pci.h includes
linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and
asm/opal-api.h. At least four of which aren't included directly by
api.c.

But I'll take you word for it :)

cheers

> diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> index 1b35e33d2434..bcc030eacab7 100644
> --- a/drivers/misc/cxl/api.c
> +++ b/drivers/misc/cxl/api.c
> @@ -11,7 +11,6 @@
>  #include <linux/slab.h>
>  #include <linux/file.h>
>  #include <misc/cxl.h>
> -#include <asm/pnv-pci.h>
>  #include <linux/msi.h>
>  #include <linux/module.h>
>  #include <linux/mount.h>