linux-kernel - Re: [PATCH] w1: omap_hdq: Free resources on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <831651485223409@web7g.yandex.ru>
Date:   Tue, 24 Jan 2017 05:03:29 +0300
From:   Evgeniy Polyakov <zbr@...emap.net>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] w1: omap_hdq: Free resources on error path

Hi Christophe

09.01.2017, 03:13, "Christophe JAILLET" <christophe.jaillet@...adoo.fr>:
> In case of error returned by '_omap_hdq_reset()', free resources as done
> elsewhere in this function.
>
> This patch slighly changes the semantic of the code. It now propagates the
> error code returned by '_omap_hdq_reset()' instead of returning -EINVAL
> unconditionally.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Looks good to me.
If kernel-janitors@ will not push it upstream feel free to send to to GregKH <greg@...ah.com>
and add me to copy.

Acked-by: Evgeniy Polyakov <zbr@...emap.net>

> ---
>  drivers/w1/masters/omap_hdq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index bb09de633939..fb190c259607 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -715,7 +715,7 @@ static int omap_hdq_probe(struct platform_device *pdev)
>          ret = _omap_hdq_reset(hdq_data);
>          if (ret) {
>                  dev_dbg(&pdev->dev, "reset failed\n");
> - return -EINVAL;
> + goto err_irq;
>          }
>
>          rev = hdq_reg_in(hdq_data, OMAP_HDQ_REVISION);
> --
> 2.9.3