linux-kernel - Re: [PATCH net-next v5] bridge: multicast to unicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Jan 2017 10:10:41 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Linus Lüssing <linus.luessing@...3.blue>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Felix Fietkau <nbd@....name>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next v5] bridge: multicast to unicast

On Sat, 21 Jan 2017 21:01:32 +0100
Linus Lüssing <linus.luessing@...3.blue> wrote:

> @@ -726,12 +729,32 @@ struct net_bridge_port_group *br_multicast_new_port_group(
>  	hlist_add_head(&p->mglist, &port->mglist);
>  	setup_timer(&p->timer, br_multicast_port_group_expired,
>  		    (unsigned long)p);
> +
> +	if (src)
> +		memcpy(p->eth_addr, src, ETH_ALEN);
> +	else
> +		memset(p->eth_addr, 0xff, ETH_ALEN);
> +
>  	return p;
>  }

Maybe use ether_addr_copy here, but is not performance critical