linux-kernel - Re: [PATCH 5/5] perf, tools, script: Add brstackasm output for branch stacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170124185410.GF10340@kernel.org>
Date:   Tue, 24 Jan 2017 15:54:10 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     jolsa@...nel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 5/5] perf, tools, script: Add brstackasm output for
 branch stacks

Em Wed, Jan 18, 2017 at 05:41:50PM -0800, Andi Kleen escreveu:
> +	memset(&al, 0, sizeof(al));
> +	if (end - start > MAXBB - MAXINSN) {
> +		if (last)
> +			printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n",
> +					start, end);
> +		else
> +			printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n",
> +					start, end, end - start);
> +		return 0;

Those are multiline if/else blocks, one has to use {}, additionally (end
- start) should be, just like the other bits PRI, fixing...

This actually broke the build in some distros, like fedora:24
crossbuilding to ARC-uClibc.

- Arnaldo