linux-kernel - Re: [PATCH] usb: storage: sddr09: Remove a set-but-not-used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Jan 2017 15:12:28 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Augusto Mecking Caringi <augustocaringi@...il.com>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>,
        <usb-storage@...ts.one-eyed-alien.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: storage: sddr09: Remove a set-but-not-used variable

On Tue, 24 Jan 2017, Augusto Mecking Caringi wrote:

> The 'isnew' variable in 'sddr09_write_lba' function is set but never
> used.
> 
> This has been detected by building the driver with W=1:
> 
> drivers/usb/storage/sddr09.c: In function ‘sddr09_write_lba’:
> drivers/usb/storage/sddr09.c:873:17: warning: variable ‘isnew’ set but
> not used [-Wunused-but-set-variable]
> int i, result, isnew;
>                  ^
> 
> Signed-off-by: Augusto Mecking Caringi <augustocaringi@...il.com>
> ---
>  drivers/usb/storage/sddr09.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/storage/sddr09.c b/drivers/usb/storage/sddr09.c
> index 3aeaa53..44f8ffc 100644
> --- a/drivers/usb/storage/sddr09.c
> +++ b/drivers/usb/storage/sddr09.c
> @@ -870,13 +870,12 @@ sddr09_write_lba(struct us_data *us, unsigned int lba,
>  	unsigned int pagelen;
>  	unsigned char *bptr, *cptr, *xptr;
>  	unsigned char ecc[3];
> -	int i, result, isnew;
> +	int i, result;
>  
>  	lbap = ((lba % 1000) << 1) | 0x1000;
>  	if (parity[MSB_of(lbap) ^ LSB_of(lbap)])
>  		lbap ^= 1;
>  	pba = info->lba_to_pba[lba];
> -	isnew = 0;
>  
>  	if (pba == UNDEF) {
>  		pba = sddr09_find_unused_pba(info, lba);
> @@ -887,7 +886,6 @@ sddr09_write_lba(struct us_data *us, unsigned int lba,
>  		}
>  		info->pba_to_lba[pba] = lba;
>  		info->lba_to_pba[lba] = pba;
> -		isnew = 1;
>  	}
>  
>  	if (pba == 1) {

Acked-by: Alan Stern <stern@...land.harvard.edu>