linux-kernel - Re: [patch] {1620} net: hns3: add dcb cap flag in init sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5888517A.1020105@huawei.com>
Date:   Wed, 25 Jan 2017 15:19:22 +0800
From:   "Yankejian (Hackim Yim)" <yankejian@...wei.com>
To:     <liguozhu@...wei.com>, <yisen.zhuang@...wei.com>,
        <huangdaode@...ilicon.com>, <lipeng321@...wei.com>,
        <davem@...emloft.net>, <robh+dt@...nel.org>, <pawel.moll@....com>,
        <mark.rutland@....com>, <ijc+devicetree@...lion.org.uk>,
        <galak@...eaurora.org>, <catalin.marinas@....com>,
        <will.deacon@....com>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>
Subject: Re: [patch] {1620} net: hns3: add dcb cap flag in init sequence

it is misoperation, please ignore. sorry to interrupt you!


On 2017/1/25 15:26, Kejian Yan wrote:
> If enable DCB feature, we need to add the capacity, and the current
> procedure cannot setting the dcb because of no capacity flag and every
> ops interface will implement by the capicity flag is enable.
>
> Signed-off-by: Kejian Yan <yankejian@...wei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 ++++--
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c   | 5 +++++
>  2 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> index 26b9b46..fffe781 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> @@ -314,12 +314,14 @@ static int hclge_configure(struct hclge_dev *hdev)
>  		hdev->tx_sch_mode = HCLGE_FLAG_TC_BASE_SCH_MODE;
>  #ifdef CONFIG_HNS3_DCB
>  		hdev->dcbx_cap = DCB_CAP_DCBX_VER_CEE |
> -			DCB_CAP_DCBX_VER_IEEE;
> +			DCB_CAP_DCBX_VER_IEEE | DCB_CAP_DCBX_HOST;
> +		hdev->flag |= HCLGE_FLAG_DCB_CAPABLE;
>  #endif /* #ifdef CONFIG_HNS3_DCB */
>  	} else {
>  		hdev->tx_sch_mode = HCLGE_FLAG_VNET_BASE_SCH_MODE;
>  #ifdef CONFIG_HNS3_DCB
> -		hdev->dcbx_cap = DCB_CAP_DCBX_VER_IEEE;
> +		hdev->dcbx_cap = DCB_CAP_DCBX_VER_IEEE | DCB_CAP_DCBX_HOST;
> +		hdev->flag |= HCLGE_FLAG_DCB_CAPABLE;
>  #endif /* #ifdef CONFIG_HNS3_DCB */
>  	}
>  
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
> index 903c413..6b00982 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
> @@ -687,6 +687,11 @@ static void hclge_tm_tc_info_init(struct hclge_dev *hdev)
>  	hdev->dcb_info_tmp.num_tc = hdev->dcb_info.num_tc;
>  	memcpy(hdev->dcb_info_tmp.tc_info, hdev->dcb_info.tc_info,
>  	       HNAE3_MAX_TC * sizeof(*hdev->dcb_info.tc_info));
> +
> +	if (hdev->dcb_info.num_tc > 1)
> +		hdev->flag |= HCLGE_FLAG_DCB_ENABLE;
> +	else
> +		hdev->flag &= ~HCLGE_FLAG_DCB_ENABLE;
>  }
>  
>  static void hclge_tm_pg_info_init(struct hclge_dev *hdev)


-- 
MBR,
Yankejian (Hackim Yim)