lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 25 Jan 2017 09:41:55 +0000
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>
CC:     <myungjoo.ham@...sung.com>, <linux-kernel@...r.kernel.org>,
        <patches@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH v2] extcon: arizona: Wait for any running HPDETs to
 complete on jack removal

On Wed, Jan 25, 2017 at 06:35:13PM +0900, Chanwoo Choi wrote:
> On 2017년 01월 25일 18:34, Charles Keepax wrote:
> > As the HPDET can't be aborted mid way through we should not allow any new
> > insertion to be processed until the previous HPDET has finished. It is very
> > unlikely but with low enough debounce settings you could start a new HPDET
> > before the old one has completed, which results in an erroneous reading.
> > 
> > Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> > ---
> > +		/*
> > +		 * If the jack was removed during a headphone detection we
> > +		 * need to wait for the headphone detection to finish, as
> > +		 * it can not be aborted. We don't want to be able to start
> > +		 * a new headphone detection from a fresh insert until this
> > +		 * one is finished.
> > +		 */
> > +		arizona_hpdet_wait(info);
> 
> If there is no necessary to handle the error return value,
> I recommend that you better to use the dev_warn() instead of dev_err().
> 
> 	dev_warn(arizona->dev, "HPDET did not appear to complete\n");
> 
> 
> How about changing the debug level with dev_warn()?
> 

Yeah can do.

Thanks,
Charles

Powered by blists - more mailing lists