linux-kernel - Re: [STLinux Kernel] [PATCH 6/8] ARM: dts: STiH407-pinctrl: Add Pinctrl group for HW flow-control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170125110112.GB5680@griffinp-ThinkPad-X1-Carbon-2nd>
Date:   Wed, 25 Jan 2017 11:01:12 +0000
From:   Peter Griffin <peter.griffin@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     gregkh@...uxfoundation.org, jslaby@...e.com,
        linux-serial@...r.kernel.org, robh+dt@...nel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, kernel@...inux.com
Subject: Re: [STLinux Kernel] [PATCH 6/8] ARM: dts: STiH407-pinctrl: Add
 Pinctrl group for HW flow-control

Hi Lee,

On Tue, 24 Jan 2017, Lee Jones wrote:

> Each serial port which supports HW flow-control should have 2 Pinctrl
> groups.  Once for when HW flow-control is in progress, where the IP

Nit: Once?

> will take over controlling the lines and another group which enables
> the lines to be toggled using GPIO mechanisms.
> 
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Acked-by: Peter Griffin <peter.griffin@...aro.org>

> ---
>  arch/arm/boot/dts/stih407-pinctrl.dtsi | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index daab16b..fbb7f86 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> @@ -465,8 +465,16 @@
>  			serial0 {
>  				pinctrl_serial0: serial0-0 {
>  					st,pins {
> -						tx = <&pio17 0 ALT1 OUT>;
> -						rx = <&pio17 1 ALT1 IN>;
> +						tx =  <&pio17 0 ALT1 OUT>;
> +						rx =  <&pio17 1 ALT1 IN>;
> +					};
> +				};
> +				pinctrl_serial0_flowctrl: serial0-0_flowctrl {
> +					st,pins {
> +						tx =  <&pio17 0 ALT1 OUT>;
> +						rx =  <&pio17 1 ALT1 IN>;
> +						cts = <&pio17 2 ALT1 IN>;
> +						rts = <&pio17 3 ALT1 OUT>;
>  					};
>  				};
>  			};