linux-kernel - Re: [PATCH 02/12] mm: introduce page_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Jan 2017 09:19:24 +0800
From:   kbuild test robot <lkp@...el.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:     kbuild-all@...org, Andrea Arcangeli <aarcange@...hat.com>,
        Hugh Dickins <hughd@...gle.com>,
        Rik van Riel <riel@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH 02/12] mm: introduce page_check_walk()

Hi Kirill,

[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.10-rc5 next-20170124]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Kirill-A-Shutemov/Fix-few-rmap-related-THP-bugs/20170125-081918
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: i386-defconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from arch/x86/include/asm/pgtable.h:471:0,
                    from include/linux/mm.h:68,
                    from include/linux/ring_buffer.h:5,
                    from include/linux/trace_events.h:5,
                    from include/trace/syscall.h:6,
                    from include/linux/syscalls.h:81,
                    from init/main.c:18:
   include/linux/rmap.h: In function 'page_check_walk_done':
>> arch/x86/include/asm/pgtable_32.h:53:24: error: implicit declaration of function 'kunmap_atomic' [-Werror=implicit-function-declaration]
    #define pte_unmap(pte) kunmap_atomic((pte))
                           ^
>> include/linux/rmap.h:253:3: note: in expansion of macro 'pte_unmap'
      pte_unmap(pcw->pte);
      ^~~~~~~~~
   cc1: some warnings being treated as errors

vim +/pte_unmap +253 include/linux/rmap.h

   237	/* Look for migarion entries rather than present ptes */
   238	#define PAGE_CHECK_WALK_MIGRATION	(1 << 1)
   239	
   240	struct page_check_walk {
   241		struct page *page;
   242		struct vm_area_struct *vma;
   243		unsigned long address;
   244		pmd_t *pmd;
   245		pte_t *pte;
   246		spinlock_t *ptl;
   247		unsigned int flags;
   248	};
   249	
   250	static inline void page_check_walk_done(struct page_check_walk *pcw)
   251	{
   252		if (pcw->pte)
 > 253			pte_unmap(pcw->pte);
   254		if (pcw->ptl)
   255			spin_unlock(pcw->ptl);
   256	}
   257	
   258	bool __page_check_walk(struct page_check_walk *pcw);
   259	
   260	/**
   261	 * page_check_walk - check if @pcw->page is mapped in @pcw->vma at @pcw->address

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (25587 bytes)