linux-kernel - Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170125113718.GA29709@gmail.com>
Date:   Wed, 25 Jan 2017 12:37:19 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Jani Nikula <jani.nikula@...ux.intel.com>
Cc:     Paulo Zanoni <paulo.r.zanoni@...el.com>,
        Ander Conselvan de Oliveira 
        <ander.conselvan.de.oliveira@...el.com>,
        "H . Peter Anvin" <hpa@...or.com>, intel-gfx@...ts.freedesktop.org,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        Dhinakaran Pandiyan <dhinakaran.pandiyan@...el.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>
Subject: Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL


* Jani Nikula <jani.nikula@...ux.intel.com> wrote:

> On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@...ux.intel.com> wrote:
> > On Wed, 25 Jan 2017, Ingo Molnar <mingo@...nel.org> wrote:
> >> * Paulo Zanoni <paulo.r.zanoni@...el.com> wrote:
> >>
> >>> So don't forget to reserve its stolen memory bits.
> >>> 
> >>> Cc: Ingo Molnar <mingo@...nel.org>
> >>> Cc: H. Peter Anvin <hpa@...or.com>
> >>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@...el.com>
> >>> Cc: x86@...nel.org
> >>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@...el.com>
> >>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@...el.com>
> >>> ---
> >>>  arch/x86/kernel/early-quirks.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>> 
> >>> Found by code inspection. This is completely untested since I don't have
> >>> GLK hardware.
> >>> 
> >>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> >>> index 6a08e25..23c4f1c 100644
> >>> --- a/arch/x86/kernel/early-quirks.c
> >>> +++ b/arch/x86/kernel/early-quirks.c
> >>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> >>>  	INTEL_SKL_IDS(&gen9_early_ops),
> >>>  	INTEL_BXT_IDS(&gen9_early_ops),
> >>>  	INTEL_KBL_IDS(&gen9_early_ops),
> >>> +	INTEL_GLK_IDS(&gen9_early_ops),
> >>>  };
> >>
> >> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
> >> changes to the i915 GPU driver?
> >
> > It's in our -next. Ack for merging this through drm-intel along with the
> > deps?

Yeah, LGTM:

  Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo