linux-kernel - [PATCH 07/23] perf tools: Add one liner warning for disabled features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170125135350.22983-8-acme@kernel.org>
Date:   Wed, 25 Jan 2017 10:53:34 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: [PATCH 07/23] perf tools: Add one liner warning for disabled features

From: Andi Kleen <ak@...ux.intel.com>

Add a one liner warning for perf features that need to be enabled
explicitly by the user, so that they know they are missing something.

Currently enabled for XED and BABELTRACE.

Committer notes:

Testing it:

  $ make O=/tmp/build/perf -C tools/perf
  make: Entering directory '/home/acme/git/linux/tools/perf'
  Makefile.config:853: Disabled features, need explicit enabling by user: XED LIBBABELTRACE
  make: Leaving directory '/home/acme/git/linux/tools/perf'
  $
  $ make O=/tmp/build/perf XED=1 -C tools/perf
  make: Entering directory '/home/acme/git/linux/tools/perf'
  Makefile.config:853: Disabled features, need explicit enabling by user:  LIBBABELTRACE
  make: Leaving directory '/home/acme/git/linux/tools/perf'
  $
  $ make O=/tmp/build/perf LIBBABELTRACE=1 -C tools/perf
  make: Entering directory '/home/acme/git/linux/tools/perf'
  Makefile.config:853: Disabled features, need explicit enabling by user:  XED
  CC       /tmp/build/perf/arch/common.o
  <SNIP>
  $
  $ make O=/tmp/build/perf XED=1 LIBBABELTRACE=1 -C tools/perf
  make: Entering directory '/home/acme/git/linux/tools/perf'
    BUILD:   Doing 'make -j4' parallel build
  make: Leaving directory '/home/acme/git/linux/tools/perf'
  $

Signed-off-by: Andi Kleen <ak@...ux.intel.com>
Suggested-and-Tested-by: Arnaldo Carvalho de Melo <acme@...hat.com>
Link: http://lkml.kernel.org/r/20170103183946.GK27864@kernel.org
Acked-by: Jiri Olsa <jolsa@...nel.org>
Link: http://lkml.kernel.org/r/20170119014150.19218-3-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/Makefile.config | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index fd798d118739..0caa11979279 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -65,6 +65,8 @@ ifneq ($(ARCH),$(filter $(ARCH),x86 arm))
   NO_LIBDW_DWARF_UNWIND := 1
 endif
 
+DISABLED_FEATURES =
+
 ifeq ($(LIBUNWIND_LIBS),)
   NO_LIBUNWIND := 1
 endif
@@ -701,6 +703,8 @@ ifdef XED
   else
     msg := $(warning No xed found, disables x86 disassembler support, please install xed);
   endif
+else
+  DISABLED_FEATURES += XED
 endif
 
 ifndef NO_LZMA
@@ -775,6 +779,8 @@ ifdef LIBBABELTRACE
   else
     msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
   endif
+else
+  DISABLED_FEATURES += LIBBABELTRACE
 endif
 
 ifndef NO_AUXTRACE
@@ -846,6 +852,10 @@ ifdef LIBCLANGLLVM
   endif
 endif
 
+ifneq ($(DISABLED_FEATURES),)
+  $(warning Disabled features, need explicit enabling by user: $(DISABLED_FEATURES))
+endif
+
 # Among the variables below, these:
 #   perfexecdir
 #   template_dir
-- 
2.9.3