linux-kernel - Re: [PATCH 06/12] mm: convert page_mkclean_one() to page_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201701250949.UZG12XNa%fengguang.wu@intel.com>
Date:   Wed, 25 Jan 2017 10:00:43 +0800
From:   kbuild test robot <lkp@...el.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:     kbuild-all@...org, Andrea Arcangeli <aarcange@...hat.com>,
        Hugh Dickins <hughd@...gle.com>,
        Rik van Riel <riel@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH 06/12] mm: convert page_mkclean_one() to page_check_walk()

Hi Kirill,

[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.10-rc5 next-20170124]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Kirill-A-Shutemov/Fix-few-rmap-related-THP-bugs/20170125-081918
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   mm/rmap.c: In function 'page_mkclean_one':
>> mm/rmap.c:1048:9: error: implicit declaration of function 'pmd_dirty' [-Werror=implicit-function-declaration]
       if (!pmd_dirty(*pmd) && !pmd_write(*pmd))
            ^~~~~~~~~
>> mm/rmap.c:1053:12: error: implicit declaration of function 'pmd_wrprotect' [-Werror=implicit-function-declaration]
       entry = pmd_wrprotect(entry);
               ^~~~~~~~~~~~~
>> mm/rmap.c:1053:10: error: incompatible types when assigning to type 'pmd_t {aka struct <anonymous>}' from type 'int'
       entry = pmd_wrprotect(entry);
             ^
>> mm/rmap.c:1054:12: error: implicit declaration of function 'pmd_mkclean' [-Werror=implicit-function-declaration]
       entry = pmd_mkclean(entry);
               ^~~~~~~~~~~
   mm/rmap.c:1054:10: error: incompatible types when assigning to type 'pmd_t {aka struct <anonymous>}' from type 'int'
       entry = pmd_mkclean(entry);
             ^
>> mm/rmap.c:1055:4: error: implicit declaration of function 'set_pmd_at' [-Werror=implicit-function-declaration]
       set_pmd_at(vma->vm_mm, address, pmd, entry);
       ^~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/pmd_dirty +1048 mm/rmap.c

  1042				set_pte_at(vma->vm_mm, address, pte, entry);
  1043				ret = 1;
  1044			} else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGE_PAGECACHE)) {
  1045				pmd_t *pmd = pcw.pmd;
  1046				pmd_t entry;
  1047	
> 1048				if (!pmd_dirty(*pmd) && !pmd_write(*pmd))
  1049					continue;
  1050	
  1051				flush_cache_page(vma, address, page_to_pfn(page));
  1052				entry = pmdp_huge_clear_flush(vma, address, pmd);
> 1053				entry = pmd_wrprotect(entry);
> 1054				entry = pmd_mkclean(entry);
> 1055				set_pmd_at(vma->vm_mm, address, pmd, entry);
  1056				ret = 1;
  1057			} else {
  1058				/* unexpected pmd-mapped page? */

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (46039 bytes)