linux-kernel - Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170125142852.GE6536@twins.programming.kicks-ass.net>
Date:   Wed, 25 Jan 2017 15:28:52 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        linux-kernel@...r.kernel.org
Cc:     Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning

On Wed, Jan 25, 2017 at 03:25:24PM +0100, Peter Zijlstra wrote:
> 
> After much waiting I finally reproduced a KASAN issue, only to find my
> trace-buffer empty of useful information because it got spooled out :/
> 
> Make kasan_report honour the /proc/sys/kernel/traceoff_on_warning
> interface.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> ---

Seems to compile better when you add the required header files...

 mm/kasan/report.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index b82b3e2..3653ed1 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -24,6 +24,7 @@
 #include <linux/types.h>
 #include <linux/kasan.h>
 #include <linux/module.h>
+#include <linux/ftrace.h>
 
 #include <asm/sections.h>
 
@@ -300,6 +301,8 @@ void kasan_report(unsigned long addr, size_t size,
 	if (likely(!kasan_report_enabled()))
 		return;
 
+	disable_trace_on_warning();
+
 	info.access_addr = (void *)addr;
 	info.access_size = size;
 	info.is_write = is_write;