linux-kernel - Re: [PATCH v4] mm: add arch-independent testcases for RODATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170125144149.GA970@bombadil.infradead.org>
Date:   Wed, 25 Jan 2017 06:41:49 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     Jinbum Park <jinb.park7@...il.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, keescook@...omium.org, arjan@...ux.intel.com,
        akpm@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, labbott@...hat.com,
        kernel-hardening@...ts.openwall.com, mark.rutland@....com,
        kernel-janitors@...r.kernel.org, linux@...linux.org.uk
Subject: Re: [PATCH v4] mm: add arch-independent testcases for RODATA

On Wed, Jan 25, 2017 at 11:18:33PM +0900, Jinbum Park wrote:
> +	/* test 2: write to the variable; this should fault */
> +	/*
> +	 * This must be written in assembly to be able to catch the
> +	 * exception that is supposed to happen in the correct case.
> +	 *
> +	 * So that probe_kernel_write is used to write
> +	 * arch-independent assembly.
> +	 */

This comment makes no sense.  Better to just delete the comment.