linux-kernel - Re: [PATCH] nvdimm: constify device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Jan 2017 18:37:22 -0800
From:   Joe Perches <joe@...ches.com>
To:     Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        dan.j.williams@...el.com, linux-nvdimm@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvdimm: constify device_type structures

On Wed, 2017-01-25 at 00:54 +0530, Bhumika Goyal wrote:
> Declare device_type structure as const as it is only stored in the
> type field of a device structure. This field is of type const, so add
> const to declaration of device_type structure.
> 
> File size before:
>   text	   data	    bss	    dec	    hex	filename
>   19278	   3199	     16	  22493	   57dd	nvdimm/namespace_devs.o
> 
> File size after:
>   text	   data	    bss	    dec	    hex	filename
>   19929	   3160	     16	  23105	   5a41	nvdimm/namespace_devs.o

Fine, but are you sure about the sizes?

It seems odd the text went up 651 bytes
while the data went down just 39 bytes.