lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 25 Jan 2017 20:39:07 +0000
From:   Mark Brown <>
To:     Dmitry Torokhov <>
Cc:     Mark Rutland <>,
        Furquan Shaikh <>,
        "Rafael J. Wysocki" <>,
        "Rafael J . Wysocki" <>,
        Liam Girdwood <>,
        Tony Lindgren <>, Len Brown <>,
        Greg Kroah-Hartman <>,
        Lorenzo Pieralisi <>,
        Hanjun Guo <>,
        Will Deacon <>,
        Rob Herring <>,
        Sathyanarayana Nujella <>,
        Heikki Krogerus <>,
        Adam Thomson <>,
        Linus Walleij <>,
        Alexandre Courbot <>,,
        ACPI Devel Maling List <>,
        Linux Kernel Mailing List <>,
        Linux OMAP Mailing List <>,
        Aaron Durbin <>,
Subject: Re: [PATCH 0/7] Implement generic regulator constraints parsing for
 ACPI and OF

On Wed, Jan 25, 2017 at 11:27:11AM -0800, Dmitry Torokhov wrote:

> For the record, the main issue for the drivers, which is being solved by
> exposing power supplies to the driver, is the following:

> 1. We suspend the device. Since there is no regulators the driver
> assumes that it will retain it's state upon resume

That's *not* a sensible thing for drivers to assume regardless of the
presence or absence of explicitly controlled regulators, that just seems
like a plain old driver bug.  Even if there are regulators that doesn't
mean there isn't a suspend mode configuration that disables those

> I would really hate to go through _every_ driver and add the following
> code to the resume path:
> 	if (acpi_device_was_powered_off_between_suspend_and_now(dev)) {
> 		completely_reinitialize_device(dev);
> 	}
> #endif

That's not an ACPI thing, unless the device thinks it's actively
providing a wakeup source then if the system suspends the driver should
not be surprised to have power pulled - that's pretty normal.  If the
driver is a wakeup source then it's a bit different.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists