linux-kernel - Re: [tpmdd-devel] [PATCH v6 0/2] enhance TPM 2.0 extend function to support multiple PCR banks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <03751871-ab12-9413-4034-e4efbf020ab4@linux.vnet.ibm.com>
Date:   Wed, 25 Jan 2017 16:08:55 -0500
From:   Stefan Berger <stefanb@...ux.vnet.ibm.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Nayna Jain <nayna@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        tpmdd-devel@...ts.sourceforge.net
Subject: Re: [tpmdd-devel] [PATCH v6 0/2] enhance TPM 2.0 extend function to
 support multiple PCR banks

On 01/25/2017 03:45 PM, Jarkko Sakkinen wrote:
> On Fri, Jan 20, 2017 at 12:05:11PM -0500, Nayna Jain wrote:
>> IMA extends its hash measurements in the TPM PCRs, based on policy.
>> The existing in-kernel TPM extend function extends only the SHA1
>> PCR bank. TPM 2.0 defines multiple PCR banks, to support different
>> hash algorithms. The TCG TPM 2.0 Specification[1] recommends
>> extending all active PCR banks to prevent malicious users from
>> setting unused PCR banks with fake measurements and quoting them.
>> This patch set adds support for extending all active PCR banks,
>> as recommended.
>>
>> The first patch implements the TPM 2.0 capability to retrieve
>> the list of active PCR banks.
>>
>> The second patch modifies the tpm_pcr_extend() and tpm2_pcr_extend()
>> interface to support extending multiple PCR banks. The existing
>> tpm_pcr_extend() interface expects only a SHA1 digest. Hence, to
>> extend all active PCR banks with differing digest sizes for TPM 2.0,
>> the SHA1 digest is padded with 0's as needed.
>>
>> [1] TPM 2.0 Specification referred here is "TCG PC Client Specific
>> Platform Firmware Profile for TPM 2.0"
> I pushed these patches. I had to resolve merge conflicts caused
> by the min_rsp_body_length parameter in tpm_transmit_cmd. Can you
> verify that I didn't break anything?

It looks like this hunk here got into the wrong patch:

@@ -1061,7 +1068,7 @@ ssize_t tpm2_get_pcr_allocation(struct tpm_chip *chip)
         tpm_buf_append_u32(&buf, 0);
         tpm_buf_append_u32(&buf, 1);

-       rc = tpm_transmit_cmd(chip, buf.data, PAGE_SIZE, 0,
+       rc = tpm_transmit_cmd(chip, buf.data, PAGE_SIZE, 9, 0,
                               "get tpm pcr allocation");
         if (rc < 0)
                 goto out;