linux-kernel - Re: [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Jan 2017 09:44:03 +0100
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Tomasz Figa <tomasz.figa@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS
 module

Hi Krzysztof,

On 2017-01-26 09:40, Krzysztof Kozlowski wrote:
> On Thu, Jan 26, 2017 at 9:18 AM, Marek Szyprowski
> <m.szyprowski@...sung.com> wrote:
>> On 2017-01-25 20:50, Krzysztof Kozlowski wrote:
>>> On Wed, Jan 25, 2017 at 12:50:28PM +0100, Marek Szyprowski wrote:
>>>> Exynos5433 LPASS module requires some clocks for proper operation with
>>>> power domain.
>>>>
>>>> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
>>>> ---
>>>>    arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>>>> b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>>>> index 57c7bbeb65a7..16072c1c3ed3 100644
>>>> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>>>> @@ -1494,6 +1494,8 @@
>>>>                  audio-subsystem@...00000 {
>>>>                          compatible = "samsung,exynos5433-lpass";
>>>>                          reg = <0x11400000 0x100>, <0x11500000 0x08>;
>>>> +                       clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
>>>> +                       clock-names = "sfr0_ctrl";
>>> You wrote that 6/7 depends on this. I prefer not to take DTS changes if
>>> the corresponding user (driver) is still under discussion because the
>>> bindings might change. I'll take it when bindings got acked or accepted.
>>
>> Well, audio support in 4.9 is still not functional due to missing other
>> patches to ALSA SoC, so nothing will break as for now if we manage to get
>> this into v4.10.
> Get this into v4.10? So this needs some additional explanation in the
> commit message why this is a fix. Probably one more sentence would be
> enough. Or did you mean v4.11?

Yes, I meant v4.11.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland