linux-kernel - Re: [PATCH V11 2/3] ACPI: Add support for ResourceSource/IRQ domain mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd7wBq7saVj_+1Zh8Dt8v59HWc6S-PdWWT84zuwO0VWTw@mail.gmail.com>
Date:   Thu, 26 Jan 2017 12:38:49 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     Agustin Vega-Frias <agustinv@...eaurora.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Timur Tabi <timur@...eaurora.org>,
        Christopher Covington <cov@...eaurora.org>,
        Andy Gross <agross@...eaurora.org>, harba@...eaurora.org,
        Jon Masters <jcm@...hat.com>, msalter@...hat.com,
        mlangsdo@...hat.com, Al Stone <ahs3@...hat.com>, astone@...hat.com,
        Graeme Gregory <graeme.gregory@...aro.org>,
        guohanjun@...wei.com,
        Charles Garcia-Tobin <charles.garcia-tobin@....com>
Subject: Re: [PATCH V11 2/3] ACPI: Add support for ResourceSource/IRQ domain mapping

On Thu, Jan 26, 2017 at 12:15 PM, Lorenzo Pieralisi
<lorenzo.pieralisi@....com> wrote:
> On Thu, Jan 26, 2017 at 03:01:18AM +0200, Andy Shevchenko wrote:
>> On Fri, Jan 20, 2017 at 4:34 AM, Agustin Vega-Frias
>> <agustinv@...eaurora.org> wrote:
>> > ACPI extended IRQ resources may contain a ResourceSource to specify
>> > an alternate interrupt controller. Introduce acpi_irq_get and use it
>> > to implement ResourceSource/IRQ domain mapping.
>> >
>> > The new API is similar to of_irq_get and allows re-initialization
>> > of a platform resource from the ACPI extended IRQ resource, and
>> > provides proper behavior for probe deferral when the domain is not
>> > yet present when called.

>> > +       list_for_each_entry(hwid, &device->pnp.ids, list) {
>>
>> > +               for (devid = &__dsdt_irqchip_acpi_probe_table;
>> > +                    devid < &__dsdt_irqchip_acpi_probe_table_end; devid++) {
>> > +                       if (devid->id && !strcmp(devid->id, hwid->id)) {
>> > +                               result = &device->fwnode;
>> > +                               break;
>> > +                       }
>> > +               }
>>
>> Looks like a candidate for linker table API. (I recommend to Cc Luis
>> for this part)
>
> This linker table entry scheme is just an optimization and should
> not gate the series.

That's correct. Though Luis might give some advice regarding to this
piece of code.

>> > +#ifdef CONFIG_ACPI_GENERIC_GSI
>>
>> #if IS_ENABLED()

>> > +int acpi_irq_get(acpi_handle handle, unsigned int index, struct resource *res);
>> > +#else
>> > +static inline int acpi_irq_get(acpi_handle handle, unsigned int index,
>> > +                              struct resource *res)
>>
>> Perhaps
>>
>> static inline
>> int ...
>
> It is late -rc5 and notwithstanding cosmetics changes, can we make
> progress with this patch series or not please ?

I agree for the second case from what's left above, first one might be
useful to amend.
At the end it's a Rafael's word, I'm not insisting on cosmetic
changes. So, what about the rest?

-- 
With Best Regards,
Andy Shevchenko