linux-kernel - Re: [PATCH] eeprom: fix memory leak on buf when failed allocation of csraddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 26 Jan 2017 15:37:15 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] eeprom: fix memory leak on buf when failed allocation of
 csraddr_str

On Tue, Jan 24, 2017 at 02:38:38PM +0000, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The error return path When csraddr_str fails to free buf, causing a
> memory leak. Fix this by returning via the free_buf label that
> performs the necessary cleanup.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/misc/eeprom/idt_89hpesx.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index 25d47d0..56bc5c2 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -965,8 +965,10 @@ static ssize_t idt_dbgfs_csr_write(struct file *filep, const char __user *ubuf,
>  		csraddr_len = colon_ch - buf;
>  		csraddr_str =
>  			kmalloc(sizeof(char)*(csraddr_len + 1), GFP_KERNEL);
> -		if (csraddr_str == NULL)
> -			return -ENOMEM;
> +		if (csraddr_str == NULL) {
> +			ret = -ENOMEM;
> +			goto free_buf;
> +		}
>  		/* Copy the register address to the substring buffer */
>  		strncpy(csraddr_str, buf, csraddr_len);
>  		csraddr_str[csraddr_len] = '\0';
> -- 
> 2.10.2
> 

Indeed. Thanks for the patch.

Acked-by: Serge Semin <fancer.lancer@...il.com>