linux-kernel - [PATCH] sysctl: fix proc_doulongvec_ms_jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485397255.5145.103.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 25 Jan 2017 18:20:55 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH] sysctl: fix proc_doulongvec_ms_jiffies_minmax()

From: Eric Dumazet <edumazet@...gle.com>

We perform the conversion between kernel jiffies and ms only
when exporting kernel value to user space.

We need to do the opposite operation when value is written
by user.

Only matters when HZ != 1000

Signed-off-by: Eric Dumazet <edumazet@...gle.com>
Cc: stable@...r.kernel.org
---
 kernel/sysctl.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 8dbaec0e4f7f079b87f50ea67c82341304387783..1aea594a54dbdac604ca950fdaf93508e5b6e6a7 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -2475,6 +2475,7 @@ static int __do_proc_doulongvec_minmax(void *data, struct ctl_table *table, int
 				break;
 			if (neg)
 				continue;
+			val = convmul * val / convdiv;
 			if ((min && val < *min) || (max && val > *max))
 				continue;
 			*i = val;