linux-kernel - Re: [PATCH] pinctrl: aspeed: g4: Fix mux configuration for GPIOs AA[4-7], AB[0-7]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 26 Jan 2017 14:43:11 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andrew Jeffery <andrew@...id.au>
Cc:     Joel Stanley <joel@....id.au>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>
Subject: Re: [PATCH] pinctrl: aspeed: g4: Fix mux configuration for GPIOs
 AA[4-7], AB[0-7]

On Mon, Jan 23, 2017 at 6:27 AM, Andrew Jeffery <andrew@...id.au> wrote:

> Incorrect video output configuration bits were being tested on pins in
> GPIO banks AA and AB for the ROM{8,16} mux functions. The ROM{8,16}
> functions are the highest priority for the relevant pins and also the
> default function, so we require the relevant video output configuration
> be disabled to mux GPIO functionality. As the wrong bits were being
> tested a GPIO export would succeed but leave the pin in an unresponsive
> state (i.e. value updates were ignored).
>
> This misbehaviour was discovered as part of extending the GPIO
> controller's support to cover banks Y, Z, AA, AB and AC (AC in the case
> of the g5 SoC).
>
> Fixes: 6d329f14a75f ("pinctrl: aspeed-g4: Add mux configuration for all pins")
> Signed-off-by: Andrew Jeffery <andrew@...id.au>

Patch applied.

Yours,
Linus Walleij