linux-kernel - Re: [PATCH v2 0/4] Style fixes: open code obfuscating macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ed3be6c-c94e-1ade-e4cd-a8e8293296cd@deltatee.com>
Date:   Thu, 26 Jan 2017 13:00:52 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Xiangliang Yu <Xiangliang.Yu@....com>,
        Jon Mason <jdmason@...zu.us>,
        Dave Jiang <dave.jiang@...el.com>,
        Allen Hubbe <Allen.Hubbe@....com>,
        Joe Perches <joe@...ches.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-ntb@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] Style fixes: open code obfuscating macros

Hi,

It's been a couple weeks... Any thoughts on this?

Thanks,

Logan

On 10/01/17 05:33 PM, Logan Gunthorpe wrote:
> Hi,
> 
> Here's an updated version of the style fixes patchset. The differences
> from v1 are:
> 
> 1) Rebased onto Jon Mason's current NTB branch
> 
> 2) Added two more patches to convert the print lines to use the ntb
> device and not the pci one. This seems more sane, shortens a bunch
> of lines and removes the need for temporaries.
> 
> Note with (2): I've tried my best to ensure that statements that print
> before the ntb device is registered still use the PCI device. However,
> someone should probably review and test this as I don't have access
> to all types of hardware to do that.
> 
> Thanks,
> 
> Logan
> 
> 
> 
> Logan Gunthorpe (4):
>   ntb_hw_amd: Style fixes: open code macros that just obfuscate code
>   ntb_hw_intel: Style fixes: open code macros that just obfuscate code
>   ntb_hw_amd: Print kernel messages with the ntb device not the pci one
>   ntb_hw_intel: Print kernel messages with the ntb device not the pci
>     one
> 
>  drivers/ntb/hw/amd/ntb_hw_amd.c     |  60 +++++------
>  drivers/ntb/hw/amd/ntb_hw_amd.h     |   3 -
>  drivers/ntb/hw/intel/ntb_hw_intel.c | 192 +++++++++++++++++-------------------
>  drivers/ntb/hw/intel/ntb_hw_intel.h |   3 -
>  4 files changed, 124 insertions(+), 134 deletions(-)
> 
> --
> 2.1.4
>