linux-kernel - Re: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485470741.12563.104.camel@perches.com>
Date:   Thu, 26 Jan 2017 14:45:41 -0800
From:   Joe Perches <joe@...ches.com>
To:     João Paulo Rechi Vita <jprvita@...il.com>,
        Corentin Chary <corentin.chary@...il.com>,
        Darren Hart <dvhart@...radead.org>
Cc:     platform-driver-x86@...r.kernel.org,
        acpi4asus-user@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
        linux@...lessm.com,
        João Paulo Rechi Vita 
        <jprvita@...lessm.com>
Subject: Re: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user
 bit are present

On Thu, 2017-01-26 at 10:30 -0500, João Paulo Rechi Vita wrote:
> Some Asus laptops that have an airplane-mode indicator LED, also have
> the WMI WLAN user bit set, and the following bits in their DSDT:

style trivia:

> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
[]
> @@ -2051,6 +2052,16 @@ static int asus_wmi_fan_init(struct asus_wmi *asus)
>  	return 0;
>  }
>  
> +static bool ashs_present(void)
> +{
> +	int i;
> +
> +	for (i = 0; strcmp(asus_wireless_ids[i].id, ""); i++)
> +		if (acpi_dev_found(asus_wireless_ids[i].id))
> +			return true;

The for loop would commonly have braces because of the
internal if.