linux-kernel - Re: [PATCH v2] openrisc: migrate exception table users off module.h and onto extable.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170126055303.GJ7836@lianli.shorne-pla.net>
Date:   Thu, 26 Jan 2017 14:53:03 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org, Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        openrisc@...ts.librecores.org
Subject: Re: [PATCH v2] openrisc: migrate exception table users off module.h
 and onto extable.h

On Wed, Jan 25, 2017 at 04:40:46PM -0500, Paul Gortmaker wrote:
> These files were only including module.h for exception table related
> functions.  We've now separated that content out into its own file
> "extable.h" so now move over to that and avoid all the extra header
> content in module.h that we don't really need to compile these files.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Cc: Jonas Bonn <jonas@...thpole.se>
> Cc: Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>
> Cc: Stafford Horne <shorne@...il.com>
> Cc: openrisc@...ts.librecores.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
> 
> [v2: add traps.c to conversion, as without a toolchain, I'm at the
>  mercy of the things found by kbuild; fixing them iteratively... ]
> 
>  arch/openrisc/kernel/traps.c | 2 +-
>  arch/openrisc/mm/fault.c     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/openrisc/kernel/traps.c b/arch/openrisc/kernel/traps.c
> index a4574cb4b0fb..73abb3ff4fa3 100644
> --- a/arch/openrisc/kernel/traps.c
> +++ b/arch/openrisc/kernel/traps.c
> @@ -23,7 +23,7 @@
>  #include <linux/init.h>
>  #include <linux/sched.h>
>  #include <linux/kernel.h>
> -#include <linux/module.h>
> +#include <linux/exception.h>

Is this correct or did you want extable.h?

>  #include <linux/kmod.h>
>  #include <linux/string.h>
>  #include <linux/errno.h>
> diff --git a/arch/openrisc/mm/fault.c b/arch/openrisc/mm/fault.c
> index b1a7435e786a..53592a639744 100644
> --- a/arch/openrisc/mm/fault.c
> +++ b/arch/openrisc/mm/fault.c
> @@ -17,7 +17,7 @@
>  
>  #include <linux/mm.h>
>  #include <linux/interrupt.h>
> -#include <linux/module.h>
> +#include <linux/extable.h>
>  #include <linux/sched.h>
>  
>  #include <linux/uaccess.h>
> -- 
> 2.11.0
>