linux-kernel - Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170126071653.GA26979@kroah.com>
Date:   Thu, 26 Jan 2017 08:16:53 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        "driverdev-devel@...uxdriverproject.org" 
        <driverdev-devel@...uxdriverproject.org>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "olaf@...fle.de" <olaf@...fle.de>,
        Rolf Neugebauer <rolf.neugebauer@...ker.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "apw@...onical.com" <apw@...onical.com>
Subject: Re: [PATCH] Drivers: hv: vmbus: finally fix
 hv_need_to_signal_on_read()

On Thu, Jan 26, 2017 at 06:10:19AM +0000, Dexuan Cui wrote:
> > From: Stephen Hemminger [mailto:stephen@...workplumber.org]
> > Sent: Wednesday, January 25, 2017 00:08
> > To: Dexuan Cui <decui@...rosoft.com>
> > Cc: gregkh@...uxfoundation.org; driverdev-devel@...uxdriverproject.org; KY
> > Srinivasan <kys@...rosoft.com>; Haiyang Zhang <haiyangz@...rosoft.com>;
> > Stephen Hemminger <sthemmin@...rosoft.com>; olaf@...fle.de; Rolf
> > Neugebauer <rolf.neugebauer@...ker.com>; jasowang@...hat.com; linux-
> > kernel@...r.kernel.org; apw@...onical.com
> > Subject: Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()
> > 
> > On Tue, 24 Jan 2017 06:54:46 +0000
> > Dexuan Cui <decui@...rosoft.com> wrote:
> > 
> > > +static inline void
> > > +init_cached_read_index(struct vmbus_channel *channel)
> > > +{
> > > +	struct hv_ring_buffer_info *rbi = &channel->inbound;
> > > +
> > > +	rbi->cached_read_index = rbi->ring_buffer->read_index;
> > > +}
> > 
> > Looks good thanks. This should go in right away. Which versions are impacted?
> > Should it also go to stable?
> 
> Yes, it needs to go to stable.
> I have Cc-ed  <stable@...r.kernel.org> in the patch's changelog, so it should be
> included in the stable tree automatically.
> 
> As I checked against the kernels listed on the homapage of www.kernel.org, the
> below versions are impacted:
> v3.16.39
> v3.18.47
> v4.1.38
> v4.8.17
> v4.9.5
> v4.10-rc5
> 
> It's interesting v4.4.44 is not impacted, but actually it needs both the 2 patches:
> i.e. this patch, and the previous one:
> Commit a389fcfd2cb5 ("Drivers: hv: vmbus: Fix signaling logic in hv_need_to_signal_on_read()")

That patch does not apply to the 4.4-stable tree, which is why it was
not included there.  If you feel it should be included, please provide a
backport and send it to the stable@...r.kernel.org mailing list.

thanks,

greg k-h