linux-kernel - Re: [PATCH] mm: migrate: add isolate_movable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 26 Jan 2017 08:39:30 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Yisheng Xie <xieyisheng1@...wei.com>,
        Minchan Kim <minchan@...nel.org>,
        Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Gioh Kim <gi-oh.kim@...fitbricks.com>,
        Ganesh Mahendran <opensource.ganesh@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: migrate: add isolate_movable_page() stub
 implementation

JFYI, Yisheng Xie has already posted a new version of the patchset [1]
and I assume Andrew will drop the current one.

[1] http://lkml.kernel.org/r/1485356738-4831-1-git-send-email-ysxie@foxmail.com

On Wed 25-01-17 23:27:38, Arnd Bergmann wrote:
> Without CONFIG_MIGRATION, we get a build failure when trying to
> call isolate_movable_page():
> 
> mm/memory-failure.c: In function '__soft_offline_page':
> mm/memory-failure.c:1656:10: error: implicit declaration of function 'isolate_movable_page';did you mean 'isolate_huge_page'? [-Werror=implicit-function-declaration]
> 
> This adds one more static inline helper function in the header
> declaring it. This returns false to indicate that the
> page was not isolated.
> 
> Fixes: mmotm ("HWPOISON: soft offlining for non-lru movable pages")
> Fixes: bda807d44454 ("mm: migrate: support non-lru movable page migration")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  include/linux/migrate.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/migrate.h b/include/linux/migrate.h
> index ae8d475a9385..09dd6e924106 100644
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -57,6 +57,9 @@ static inline int migrate_pages(struct list_head *l, new_page_t new,
>  		int reason)
>  	{ return -ENOSYS; }
>  
> +static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode)
> +	{ return false; }
> +
>  static inline int migrate_prep(void) { return -ENOSYS; }
>  static inline int migrate_prep_local(void) { return -ENOSYS; }
>  
> -- 
> 2.9.0

-- 
Michal Hocko
SUSE Labs