linux-kernel - Re: [char-misc-next V3] mei: simplify error handling via devres function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170127081515.GA29246@kroah.com>
Date:   Fri, 27 Jan 2017 09:15:15 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Tomas Winkler <tomas.winkler@...el.com>
Cc:     Alexander Usyskin <alexander.usyskin@...el.com>,
        linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [char-misc-next V3] mei: simplify error handling via devres
 function.

On Thu, Jan 26, 2017 at 05:16:26PM +0200, Tomas Winkler wrote:
> Use devm_ and pcim_ functions to make error handling
> simpler and code smaller and tidier.
> 
> Based on original patch by
> mei: me: use managed functions pcim_* and devm_*
> https://lkml.org/lkml/2016/2/1/339
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@...el.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> V2: Thanks Andy for review, integratd changes:
>     1. Rename devm_mei_me_init back to mei_me_dev_init
>        they don't really belong to devm_ namespace.
>     2. Revert pcim irq reservation change.
>     3. Drop setting driver data to NULL on exit.
>     4. Use directly mmio pointer received from pcim_iomap_table
> V3: Remove pci_disable_msi, it is also handled by the system.

Andy, any objection to this version?

thanks,

greg k-h