linux-kernel - Re: [PATCH RESEND] phy: fix rockchip-inno-usb2 build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <588B01A9.2030202@ti.com>
Date:   Fri, 27 Jan 2017 13:45:37 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Randy Dunlap <rdunlap@...radead.org>
CC:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Heiko Stuebner <heiko@...ech.de>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] phy: fix rockchip-inno-usb2 build errors



On Thursday 26 January 2017 11:12 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix build errors in phy-rockchip-inno-usb2.c. The driver uses
> extcon interfaces so it should depend on EXTCON.
> 
> Fixes these build errors:
> 
> drivers/built-in.o: In function `rockchip_usb2phy_otg_sm_work':
> phy-rockchip-inno-usb2.c:(.text+0x2bcb): undefined reference to `extcon_get_state'
> phy-rockchip-inno-usb2.c:(.text+0x2cd4): undefined reference to `extcon_set_state_sync'
> phy-rockchip-inno-usb2.c:(.text+0x2cec): undefined reference to `extcon_set_state_sync'
> phy-rockchip-inno-usb2.c:(.text+0x2d2d): undefined reference to `extcon_get_state'
> drivers/built-in.o: In function `rockchip_usb2phy_probe':
> phy-rockchip-inno-usb2.c:(.text+0x31d7): undefined reference to `extcon_get_edev_by_phandle'
> phy-rockchip-inno-usb2.c:(.text+0x321a): undefined reference to `devm_extcon_dev_allocate'
> phy-rockchip-inno-usb2.c:(.text+0x3230): undefined reference to `devm_extcon_dev_register'
> phy-rockchip-inno-usb2.c:(.text+0x375a): undefined reference to `extcon_register_notifier'
> 
> Found in linux-next but is also needed in mainline.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>
> Cc:	Chanwoo Choi <cw00.choi@...sung.com>
> Cc:	Heiko Stuebner <heiko@...ech.de>
> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

merged, thanks.

-Kishon
> ---
>  drivers/phy/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20170124.orig/drivers/phy/Kconfig
> +++ linux-next-20170124/drivers/phy/Kconfig
> @@ -363,6 +363,7 @@ config PHY_ROCKCHIP_INNO_USB2
>  	tristate "Rockchip INNO USB2PHY Driver"
>  	depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
>  	depends on COMMON_CLK
> +	depends on EXTCON
>  	depends on USB_SUPPORT
>  	select GENERIC_PHY
>  	select USB_COMMON
>